Wrapped json support #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error returning is different output formats. Concreteley, the way a wrapped_json response is different from the others, So we tell to the error response the output format it must use (The one in the query) If there is no OutputFormat header in the query, we'll use the default one (csv)
…d-livestatus into wrapped_json_support
This is needed to interoperatibility
…d-livestatus into wrapped_json_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the output format "wrapped_json".
This format, supported by LMD, includes information about the data length and the errors that may have been occurred. Summing up, this format returns additional information in the response.
The aiming of including this format is the interest to know what happened if a query fails for some reason in order to fix it or handle the error if there was any, because at the moment if the query fails, the reader in the socket cannot know it without looking at the broker logs.